feat: Added switch to set variable as secret #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-scripting ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pim-simons
added
enhancement
|
Looking at the code and testing the currently released version, it does not seem that this task worked correctly... |
stijnmoreels
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Oh, so this is a bugfix and feature in one, great! 😄
Since this only works on a build server, it is indeed a bit harder to tests locally. Maybe we could check if there is an environment variable available after running the command instead of asserting on the Write-Host?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a switch to set a variable as a secret.
Closes #379